Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment On Forks Instead Writes To Artifact #322

Merged
merged 22 commits into from
Jun 25, 2024

Conversation

supitscaro
Copy link
Contributor

@supitscaro supitscaro commented Jun 23, 2024

Motivation

In the situation of a fork (such as this PR), we don't have access to a token with permissions to post a comment. In this situation, we will instead upload that content as an artifact to the workflow. Another workflow / job can then handle that posting of the comment.

Approach

Upload comment as artifact on comment failure.

@jbolda jbolda changed the title test gh actions Comment On Forks Instead Writes To Artifact Jun 23, 2024
@jbolda jbolda self-requested a review June 23, 2024 04:28
Copy link
Contributor

github-actions bot commented Jun 25, 2024

Package Changes Through 417eb94

There are 9 changes which include covector with minor, action with minor, @covector/apply with minor, @covector/assemble with minor, @covector/changelog with minor, @covector/files with minor, @covector/command with minor, @covector/toml with minor, @covector/types with minor

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
covector 0.11.0 0.12.0
@covector/apply 0.9.3 0.10.0
@covector/assemble 0.11.0 0.12.0
@covector/changelog 0.11.0 0.12.0
@covector/files 0.7.2 0.8.0
@covector/command 0.7.1 0.8.0
@covector/toml 0.1.0 0.2.0
@covector/types 0.0.0 0.1.0
action 0.11.0 0.12.0

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

Copy link
Owner

@jbolda jbolda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for your help with checking this works across a fork @echocaro!

@jbolda jbolda merged commit e5d2be5 into jbolda:main Jun 25, 2024
5 checks passed
@github-actions github-actions bot mentioned this pull request Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants